Upgrade to urfave/cli v3, spinners, build metadata - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to urfave/cli v3, spinners, build metadata
urfave/cli v2 → v3
Moves to
github.com/urfave/cli/v3 v3.11.0, matching osctrl.EnvVars: []string{"X"}→Sources: cli.EnvVars("X"), across all 13 flags.*cli.Commandinstead of*cli.App;Runtakes acontext.Context.func(context.Context, *cli.Command) error. The*cli.Contextargument was unused in all seven action functions, so no bodies changed.IntFlagis stillint-backed in v3, soConfiguration.Intervaland everyDestinationpointer are untouched.Spinners
New
ui.goports the braille spinner from osctrl'scmd/cli/shell_ui.go— no new direct dependency.enroll/removescript output to a shell stays clean.--verboseis off, andlogFormatis notjson. Theservicedaemon never spins.Build metadata
Follows osctrl-cli:
buildVersion/buildCommit/buildDatevars inmain,--version/-vprintingosctrld version=X commit=Y date=Z.GoReleaser's four builds swap the dead
-X main.versionfor the three-X main.build*flags, and the Makefile gains matchingBUILD_ARGS.